Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[v1.9-branch] RHOAIENG-10827: feat(nbcs): update ose-oauth-proxy image digest reference from 4.8 to the latest 4.14 version (#388)" #419

Conversation

jiridanek
Copy link
Member

Description

We found at least one OCP cluster where this change causes restart of running notebooks when controller is updated from a previous version to a version with this fix present. To be safe, we'll roll this back and try again. We'll investigate that cluster to understand what's happening.

This reverts commit 99e70bf.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…oxy image digest reference from 4.8 to the latest 4.14 version (opendatahub-io#388)"

We found at least one OCP cluster where this change causes restart of running notebooks when controller is updated from a previous version
to a version with this fix present. To be safe, we'll roll this back and try again. We'll investigate that cluster to understand what's happening.

This reverts commit 99e70bf.
@jiridanek
Copy link
Member Author

/cherrypick v1.9-branch

@openshift-cherrypick-robot

@jiridanek: once the present PR merges, I will cherry-pick it on top of v1.9-branch in a new PR and assign it to you.

In response to this:

/cherrypick v1.9-branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/cc @jstourac @harshad16

@jiridanek
Copy link
Member Author

There are no objections, so
/lgtm
/approve

Copy link

openshift-ci bot commented Oct 16, 2024

@jiridanek: you cannot LGTM your own PR.

In response to this:

There are no objections, so
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek jiridanek added the lgtm label Oct 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c3d9c8b into opendatahub-io:main Oct 16, 2024
12 checks passed
@openshift-cherrypick-robot

@jiridanek: new pull request created: #421

In response to this:

/cherrypick v1.9-branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants